Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Support NumPy-compatible bitwise_and #16861

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Nov 20, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • np.bitwise_and
  • Unit tests

Comments

First version contributed by @zoeygxy in #16009, now adapted to fit the new implementation conventions.

@haojin2 haojin2 added the Numpy label Nov 20, 2019
@haojin2 haojin2 requested a review from szha as a code owner November 20, 2019 01:36
@haojin2 haojin2 self-assigned this Nov 20, 2019
@haojin2 haojin2 force-pushed the np_bitwise_and branch 5 times, most recently from 9dd6f5c to 135bd8f Compare November 27, 2019 00:53
@reminisce reminisce merged commit 1da0eb8 into apache:master Jan 30, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants